Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.2 support #3202

Closed
OHHI0321 opened this issue Sep 25, 2023 · 14 comments
Closed

1.20.2 support #3202

OHHI0321 opened this issue Sep 25, 2023 · 14 comments

Comments

@OHHI0321
Copy link

I tried this code on vsc, but it says:
Error: unsupported/unknown protocol version: 764, update minecraft-data
at F:\모듈\마인크래프트봇\node_modules\minecraft-protocol\src\client\autoVersion.js:32:28
at F:\모듈\마인크래프트봇\node_modules\minecraft-protocol\src\ping.js:13:7
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
TypeError: Cannot read properties of undefined (reading 'minecraftVersion')
at F:\모듈\마인크래프트봇\node_modules\minecraft-protocol\src\client\autoVersion.js:34:42
at F:\모듈\마인크래프트봇\node_modules\minecraft-protocol\src\ping.js:13:7
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

[index.js]
const mineflayer = require("mineflayer");

const bot = mineflayer.createBot({
host: "mjbsv189.aternos.me",
port: 16426,
username: "noH33XD"
})

bot.on("login", () => {
console.log("Logged in");
})

@OHHI0321 OHHI0321 added possible bug Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f labels Sep 25, 2023
@PondWader
Copy link
Contributor

Yes, 1.20.2 is not supported yet.

@extremeheat extremeheat changed the title 1.20.2 is not working? 1.20.2 support Sep 25, 2023
@extremeheat extremeheat added new feature contribution-wanted and removed possible bug Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f labels Sep 25, 2023
@akirataguchi115
Copy link

What are the usual steps needed so that we can up the version to 1.20.2? I can make a few pull requests if needed.

@wgaylord
Copy link
Contributor

Firstly from my understanding https://github.com/PrismarineJS/minecraft-data needs to be updated for 1.20.2 (New folder with all the appropriate JSON files.)

@2pla
Copy link

2pla commented Nov 5, 2023

any updates?
cuz i see that minecraft-data has been updated to 1.20.2

@rom1504
Copy link
Member

rom1504 commented Nov 5, 2023 via email

@alexpolo1
Copy link

Any update on this?

@rom1504
Copy link
Member

rom1504 commented Dec 4, 2023 via email

@alexpolo1
Copy link

Sadly no. Do you want to help? Next task is adding support in
node-minecraft-protocol

On Mon, Dec 4, 2023, 08:00 alexpolo1 @.***> wrote:

Any update on this?


Reply to this email directly, view it on GitHub
#3202 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAR437XSMFDH52VHRR7QSSTYHVYJDAVCNFSM6AAAAAA5F7AAGOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXHE2DSMRQGE
.
You are receiving this because you commented.Message ID:
@.***>

What's the requiremet ?

@crux153
Copy link
Contributor

crux153 commented Dec 12, 2023

I opened a PR at #3243 that achieves basic 1.20.2 support.

To get it working, it's necessary to apply patches to both prismarine-nbt and node-minecraft-protocol. Cloning my branches and copying it over node_modules would work fine.

I tested that a bot can successfully log in to an offline server and do some interactions (chat, detecting blocks and entities, activating levers and buttons, ...etc). But please do some testings.

@rom1504
Copy link
Member

rom1504 commented Dec 27, 2023

ongoing work at #3243

@rom1504 rom1504 pinned this issue Dec 28, 2023
@extremeheat
Copy link
Member

If anyone would like to test, the remaining things are at #3262 (comment)

@MoWobbler
Copy link

MoWobbler commented Jan 16, 2024

1.20.2 support is done right? Is work being done on 1.20.3 and 1.20.4?

@wgaylord
Copy link
Contributor

1.20.2 support is done right? Is work being done on 1.20.3 and 1.20.4?

That is waiting on PrismarineJS/node-minecraft-protocol#1275 or at least some form of it.

@extremeheat
Copy link
Member

1.20.2 is done in #3262

@extremeheat extremeheat unpinned this issue Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants