-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically extract all available versions #17
Comments
should we not rather "retire" old versions once a new one comes out? In other words: Could we run into issues writing an extraction code in 2020 for version 1.15.2 and try to re-run that same code in 2025 again? Is there a chance that wiki changes are so dramatic that even the page history is not valid anymore? In this case I would argue that we should commit the results of this package to this same repo for every version once the next version comes out. This would also allow us to have only the code running that pulls the current version and not keep/maintain the code that parses historical wiki formats. |
This may happen but the wiki isn't written by mojang itself. That means the content may be lacking some information that may be added in the future. Rather than dropping support for older versions there should be tests that check if everything has been extracted (and maybe if it's been extracted correctly) |
Sounds good to me. Anyhow we can always keep the code for older versions, no need to actively delete it. My point is rather that the default execution of this package should retrieve only the latest version instead of indefinetely at every run try to re-retrieve all previous version (as a black/white scenario) |
I think actually the main question is what do we need the wiki extractor
for now that burger extractor is ok ?
…On Thu, May 14, 2020, 11:15 Uncovery ***@***.***> wrote:
Sounds good to me. Anyhow we can always keep the code for older versions,
no need to actively delete it. My point is rather that the default
execution of this package should retrieve only the latest version instead
of indefinetely at every run try to re-retrieve all previous version (as a
black/white scenario)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR437VTGG4XNRKMW2RTC7LRROZDDANCNFSM4CSG3MJQ>
.
|
Does it have the enchantments on the burger extractor? And those block icons? |
No description provided.
The text was updated successfully, but these errors were encountered: