Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically extract all available versions #17

Open
rom1504 opened this issue Oct 8, 2016 · 5 comments
Open

Automatically extract all available versions #17

rom1504 opened this issue Oct 8, 2016 · 5 comments

Comments

@rom1504
Copy link
Member

rom1504 commented Oct 8, 2016

No description provided.

@uncovery
Copy link

should we not rather "retire" old versions once a new one comes out? In other words: Could we run into issues writing an extraction code in 2020 for version 1.15.2 and try to re-run that same code in 2025 again? Is there a chance that wiki changes are so dramatic that even the page history is not valid anymore? In this case I would argue that we should commit the results of this package to this same repo for every version once the next version comes out. This would also allow us to have only the code running that pulls the current version and not keep/maintain the code that parses historical wiki formats.

@wvffle
Copy link
Member

wvffle commented May 14, 2020

This may happen but the wiki isn't written by mojang itself. That means the content may be lacking some information that may be added in the future.

Rather than dropping support for older versions there should be tests that check if everything has been extracted (and maybe if it's been extracted correctly)

@uncovery
Copy link

Sounds good to me. Anyhow we can always keep the code for older versions, no need to actively delete it. My point is rather that the default execution of this package should retrieve only the latest version instead of indefinetely at every run try to re-retrieve all previous version (as a black/white scenario)

@rom1504
Copy link
Member Author

rom1504 commented May 14, 2020 via email

@uncovery
Copy link

uncovery commented May 14, 2020

Does it have the enchantments on the burger extractor? And those block icons?
I could only find the enchantments in the language file as a simple list, but no additional information such as levels etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants