Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light emitting values of blocks #96

Closed
rom1504 opened this issue Feb 7, 2016 · 8 comments
Closed

Light emitting values of blocks #96

rom1504 opened this issue Feb 7, 2016 · 8 comments
Labels

Comments

@rom1504
Copy link
Member

rom1504 commented Feb 7, 2016

@hansihe was saying in #mcdevs that http://minecraft.gamepedia.com/Light#Light-emitting_blocks are interesting values
Possibilities:

(it would anyway be exposed as a single block thing in wrappers)

@rom1504
Copy link
Member Author

rom1504 commented Feb 7, 2016

A benefit of blocks_lights.json is it could be written manually to begin with ;)

@rom1504
Copy link
Member Author

rom1504 commented Feb 13, 2016

fixed by #102

@rom1504 rom1504 closed this as completed Feb 13, 2016
@nickelpro
Copy link
Member

Right now light emitting blocks such as lava are listed as "transparent" when that's not really true. They're opaque light emitters in their own right, not transparent to the light level above them.

@rom1504
Copy link
Member Author

rom1504 commented Feb 15, 2016

Hmm the wiki do list lava as transparent http://minecraft.gamepedia.com/Lava

@hansihe how would you handle lava in your light handling thing ?

(also see WIP in PrismarineJS/minecraft-wiki-extractor#12 )

@hansihe
Copy link
Contributor

hansihe commented Feb 15, 2016

I do think what @nickelpro is saying is technically true, but I don't think it realistically matters since lava emits the highest possible light level, 15.

Edit:
To clarify, the lava block would still be transparent in blocks.json, however it would have filterlight 15.

@hansihe
Copy link
Contributor

hansihe commented Feb 15, 2016

Lava would be handled just like a normal light emitting block. Since light emitters don't affect blocks that are lit up to a higher light level by another light emitter, and lava emits the highest possible light level, 15, I don't think there is any possible way changing the filterlight of lava would make any difference.

@Gjum
Copy link
Member

Gjum commented Feb 15, 2016

This could be verified by creating a closed room with only lava (/glowstone/redstone lamps) as walls and looking at the skylight in the F3 screen.

@hansihe
Copy link
Contributor

hansihe commented Feb 15, 2016

@Gjum has a point, what I said earlier was false. If I'm not mistaken, the filterlight value of lava would in fact affect skylight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants