-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for protocol 748 (1.21.40) #930
Conversation
dataPaths.json broken, fix it |
I see... Weird, I used incrementVersion.js so I've no idea why those mistakes are there |
Edit: It can't seem to find the BDS download linkI'm looking for it now but something will probably need to be changed in minecraft-bedrock-server or whatever code downloads BDS |
data/bedrock/latest/proto.yml
Outdated
@@ -652,7 +649,7 @@ packet_move_player: | |||
source_entity_type: LegacyEntityType | |||
tick: varint64 | |||
|
|||
packet_rider_jump: | |||
packet_passenger_jump: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't rename packets unless it's a different packet (same for fields holding same data), this unnecessarily breaks code compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if there does need to be a rename for something, it should be backported to the old versions. I've fixed this one.
Thanks for working on this! |
/makerelease |
No description provided.