Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for protocol 748 (1.21.40) #930

Merged
merged 8 commits into from
Oct 25, 2024

Conversation

CreeperG16
Copy link
Contributor

No description provided.

@pokecosimo
Copy link
Contributor

dataPaths.json broken, fix it

@CreeperG16
Copy link
Contributor Author

I see... Weird, I used incrementVersion.js so I've no idea why those mistakes are there

@CreeperG16
Copy link
Contributor Author

CreeperG16 commented Oct 24, 2024

It seems CI is failing because BDS isn't starting up in time? Not entirely sure what's up with that

1.21.40
Starting dump server 1.21.40
Downloading server linux 1.21.40 into bds-
Opening https://minecraft.azureedge.net/bin-linux/bedrock-server-1.21.40.00.zip 1729796437257
Opening https://minecraft.azureedge.net/bin-linux/bedrock-server-1.21.40.01.zip 1729796437995
Opening https://minecraft.azureedge.net/bin-linux/bedrock-server-1.21.40.02.zip 1729796438649
Opening https://minecraft.azureedge.net/bin-linux/bedrock-server-1.21.40.03.zip 1729796439278
Opening https://minecraft.azureedge.net/bin-linux/bedrock-server-1.21.40.04.zip 1729796439911
Opening https://minecraft.azureedge.net/bin-linux/bedrock-server-1.21.40.05.zip 1729796440537
Opening https://minecraft.azureedge.net/bin-linux/bedrock-server-1.21.40.06.zip 1729796441170
Opening https://minecraft.azureedge.net/bin-linux/bedrock-server-1.21.40.07.zip 1729796441796
Error: Server did not start on time (60000ms, now 1729796497313)
    at /home/runner/work/minecraft-data/minecraft-data/bedrock-protocol/tools/startVanillaServer.js:132:11
    at waitFor (/home/runner/work/minecraft-data/minecraft-data/bedrock-protocol/src/datatypes/util.js:30:32)
    at async startServerAndWait (/home/runner/work/minecraft-data/minecraft-data/bedrock-protocol/tools/startVanillaServer.js:[12](https://github.com/PrismarineJS/minecraft-data/actions/runs/11505320172/job/32026763933?pr=930#step:10:13)8:3)
    at async Object.startServerAndWait2 (/home/runner/work/minecraft-data/minecraft-data/bedrock-protocol/tools/startVanillaServer.js:[13](https://github.com/PrismarineJS/minecraft-data/actions/runs/11505320172/job/32026763933?pr=930#step:10:14)9:12)
    at async dump (/home/runner/work/minecraft-data/minecraft-data/bedrock-protocol/tools/genPacketDumps.js:28:18)
    at async startTest (/home/runner/work/minecraft-data/minecraft-data/bedrock-protocol/test/internal.js:[16](https://github.com/PrismarineJS/minecraft-data/actions/runs/11505320172/job/32026763933?pr=930#step:10:17):3)

Edit: It can't seem to find the BDS download link

I'm looking for it now but something will probably need to be changed in minecraft-bedrock-server or whatever code downloads BDS

@@ -652,7 +649,7 @@ packet_move_player:
source_entity_type: LegacyEntityType
tick: varint64

packet_rider_jump:
packet_passenger_jump:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't rename packets unless it's a different packet (same for fields holding same data), this unnecessarily breaks code compatibility

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if there does need to be a rename for something, it should be backported to the old versions. I've fixed this one.

@extremeheat
Copy link
Member

Thanks for working on this!

@extremeheat extremeheat merged commit dee9f10 into PrismarineJS:master Oct 25, 2024
4 checks passed
@extremeheat
Copy link
Member

/makerelease

@rom1504bot rom1504bot mentioned this pull request Oct 25, 2024
@CreeperG16 CreeperG16 deleted the bedrock_1.21.40 branch October 25, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants