You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am in the process of building a library to work with the minecraft protocol in c#. Like all libraries, I need support for all minecraft packets, so I decided to generate them using this repository. While reading protodef I noticed a few issues that prevent me from fully generating packets:
The Slot type has an anonymous field and a present field, when it would be possible to make the Slot type just optional container:
On version 1.13.X there is a tags type in the play.toClient namespace, which is supposed to be declared at the beginning, i.e. in types. This does not contradict protodef, but it is not uniform.
I can explain number 4. anonymousNbt is its own type, introduced in new versions where the root tag does not send a tag name. So in 1.13 it is still normal nbt since root tags require names in that verison.
I am in the process of building a library to work with the minecraft protocol in c#. Like all libraries, I need support for all minecraft packets, so I decided to generate them using this repository. While reading protodef I noticed a few issues that prevent me from fully generating packets:
On version 1.13.X there is a tags type in the play.toClient namespace, which is supposed to be declared at the beginning, i.e. in types. This does not contradict protodef, but it is not uniform.
minecraft-data/data/pc/1.13.2/protocol.json
Line 3931 in a748994
Switch constructs sometimes have cases that are objects(container) and don't have a name, just a number.
Old versions had the type nbt, now it is called anonymousNbt. Why it was necessary to change the name is unclear.
Question: can I rely on these problems being fixed, or should I choose another way to generate packets?
The text was updated successfully, but these errors were encountered: