Add some 1.20.5 data #879
Merged
Add some 1.20.5 data #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
extremeheat
reviewed
Jun 16, 2024
data/pc/1.20.5/foods.json
Outdated
| @@ -0,0 +1 @@ | |||
| [] | |||
There was a problem hiding this comment.
is this supposed to be blank?
There was a problem hiding this comment.
Likely a failure of the extractor, this would need to be fixed. Doesn't seem like there was any changes to 1.20.5 food list so it may be possible to write a script to just update the item IDs.
| @@ -0,0 +1,1302 @@ | |||
| [ | |||
There was a problem hiding this comment.
ok for now, but there is additional data to extract here with the extractor in tools/js/extractMcpcEntityMetadata for extracting metadata keys (used in mineflayer)
extremeheat
reviewed
Jun 16, 2024
| @@ -0,0 +1,58 @@ | |||
| const fs = require('fs') | |||
There was a problem hiding this comment.
I fixed the foods for now with a new extraction script here via the source code
|
LGTM @rom1504 |
|
Going to merge this to not conflict with/block 1.20.5 protocol data |
|
Thanks for handling it @extremeheat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.20.5 update