Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 1.20.71 correctPlayerMovePredictionPacket missing prediction_type #870

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Cdm2883
Copy link

@Cdm2883 Cdm2883 commented Apr 16, 2024

No description provided.

@extremeheat
Copy link
Member

Can you apply this fix to previous versions where it's also applicable?

@Cdm2883
Copy link
Author

Cdm2883 commented Apr 18, 2024

Can you apply this fix to previous versions where it's also applicable?

The update to this packet structure seems to start in protocol 662, only 1.20.70+

@extremeheat
Copy link
Member

Where are you seeing that? Seems like it should be applied since 1.20.40 (protocol v622)

https://github.com/Mojang/bedrock-protocol-docs/blob/main/html/svg/CorrectPlayerMovePredictionPacket.svg

@Cdm2883
Copy link
Author

Cdm2883 commented Apr 19, 2024

Where are you seeing that? Seems like it should be applied since 1.20.40 (protocol v622)

https://github.com/Mojang/bedrock-protocol-docs/blob/main/html/svg/CorrectPlayerMovePredictionPacket.svg

Sorry, I only noticed a change in the structure of the packet in protocol 662, so I may have made an incorrect subjective judgment without checking.

I'll try to try triggering the packet at previous versions of BDS later and then confirm the final situation.

@rom1504
Copy link
Member

rom1504 commented Jul 26, 2024

should we merge this @extremeheat ?

@Cdm2883
Copy link
Author

Cdm2883 commented Jul 26, 2024

should we merge this @extremeheat ?

I don't think this should be done at this time. I haven't freed up time to check previous versions lately, and then there's the fact that I've found more wrong in packets, and I'd like to continue fixing other packets on this PR :D

Should the status of this PR go to draft or something like that?

@Cdm2883 Cdm2883 marked this pull request as draft July 26, 2024 16:59
@rom1504
Copy link
Member

rom1504 commented Jul 26, 2024

Up to you about the status, but thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Almost too old
Development

Successfully merging this pull request may close these issues.

3 participants