Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

things to check before prod #1

Closed
3 tasks done
u9g opened this issue May 10, 2022 · 18 comments
Closed
3 tasks done

things to check before prod #1

u9g opened this issue May 10, 2022 · 18 comments

Comments

@u9g
Copy link
Member

u9g commented May 10, 2022

  • air is not diggable
  • grass_block and dirt have effective tools
  • dont add repairWith if it's empty
@u9g
Copy link
Member Author

u9g commented May 10, 2022

eventually would be nice to add cake food/sat to foods.json

@u9g
Copy link
Member Author

u9g commented May 10, 2022

  • 1.15's lootContextBuilder should add .put(LootContextParameters.BLOCK_STATE, blockState) ...etc

@u9g
Copy link
Member Author

u9g commented May 12, 2022

  • so many versions have maxDurability wrong, it should be item#getMaxDamage

@u9g
Copy link
Member Author

u9g commented May 18, 2022

  • round depth to 2 decimals, or just like all numbers

Use BigDecimal in food data generator

@u9g
Copy link
Member Author

u9g commented May 18, 2022

  • remove the currentEnvironment == EnvType.CLIENT from every version:
if (currentEnvironment == EnvType.CLIENT) {
    constantTintColors = generateConstantTintColors();
}

@u9g
Copy link
Member Author

u9g commented May 20, 2022

  • rename ClientSideAnnoyances to be lowercase

@u9g
Copy link
Member Author

u9g commented May 20, 2022

  • most versions dont need MiningToolAccessor, there is a item.getEffectiveBlocks()...

@u9g
Copy link
Member Author

u9g commented May 21, 2022

  • add attributes.json to all versions (1.16+, resources have minecraft: prefix)

@u9g
Copy link
Member Author

u9g commented May 21, 2022

  • enchantment.isDifferent in EnchantmentsDataGenerator should have a not before it, ie:
            if (!enchantment.isDifferent(other) && other != enchantment) {

@u9g
Copy link
Member Author

u9g commented May 21, 2022

  • make sure getMaximumPower is properly used on all enchants, since it is overridden
-        int b = getMaximumPower(enchantment,0);
-        int a = getMaximumPower(enchantment,1) - b;
+        int b = enchantment.getMaximumPower(0);
+        int a = enchantment.getMaximumPower(1) - b;

@u9g
Copy link
Member Author

u9g commented May 22, 2022

  • update SkyColors from 1.11.2

@u9g
Copy link
Member Author

u9g commented May 22, 2022

  • remove stackSize from blocks.json in all versions

@u9g
Copy link
Member Author

u9g commented May 22, 2022

  • remove this comment
        // FIXME: ENTITY ID IS WRONG

@u9g
Copy link
Member Author

u9g commented May 22, 2022

  • vanishable should not be in the enchantCategories for all items in items.json...

@u9g
Copy link
Member Author

u9g commented May 22, 2022

  • make sure BlockDataDumper's emitLight is correct for all versions

@u9g
Copy link
Member Author

u9g commented May 22, 2022

  • replace DGU.getCurrentlyRunningServer().stopServer(); with System.exit(0) everywhere

@rom1504
Copy link
Member

rom1504 commented Dec 31, 2023

@AlexProgrammerDE any thoughts on those ?

@rom1504
Copy link
Member

rom1504 commented Oct 27, 2024

I think this is basically done

@rom1504 rom1504 closed this as completed Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants