Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leftover cosmic ray transport and diffusion changes #570

Open
2 tasks
felker opened this issue Mar 12, 2024 · 1 comment
Open
2 tasks

Leftover cosmic ray transport and diffusion changes #570

felker opened this issue Mar 12, 2024 · 1 comment

Comments

@felker
Copy link
Contributor

felker commented Mar 12, 2024

Follow up from #550 (mostly stuff for @yanfeij to generally weigh in on that PR)

  • I still think that it is unfortunate that there is no consistency in variable names between the two CR algorithms. E.g. Dpara/Dperp vs. sigma_diff(0:2, ...), initial condition set via pcrdiff->ecr(k,j,i) vs. pcr->u_cr(4,k,j,i), even though they are in different modules and have different array dimensions as @tomidakn emphasizes
  • https://github.com/PrincetonUniversity/athena/wiki/Cosmic-Ray-Transport only describes cr/vmax and EnrollOpacityFunction(). Need to describe some other parameters and functions in the class, especially those related to CR streaming and source functions. Also would be good to include the counterpart of the "equations solved" copied from Jiang and Oh (2018), assuming that they are different from the CR diffusion equations with the inclusion of the velocity-related terms. This is related to making the names consistent between CR diffusion and transport modules. Some items from cr.hpp header:
  Real vlim;
  Real max_opacity;
  AthenaArray<Real> sigma_adv;  // KGF: show an example of how this is set in the enroll functions 
...
  // Function in problem generators to update opacity
...
  void EnrollStreamingFunction(CRStreamingFunc MyStreamingFunction);

  void EnrollUserCRSource(CRSrcTermFunc my_func);
@felker felker mentioned this issue Apr 1, 2024
@felker
Copy link
Contributor Author

felker commented Apr 30, 2024

delaying until after the 24.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant