-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some figures use serif CJK, others use sans #367
Comments
@gwijthoff Gissoo designed them (or at least some of them) to use sans serif because she wanted it to be more readable. Nick wanted to switch some of them to serif because it was representing historical content. It seems ok to me for them to be different if they are serving different purposes, but I defer to @thatbudakguy on that. I know he had planned to open a PR with an update to change the ones he wanted updated, but I've lost track whether that's been done. |
it has not been done, but I want to – sorry! maybe today. |
@thatbudakguy if you tell me which figures / or portions or remind me if you already made a note of this somewhere I'll see if I can get to it today. |
If the intent is to have some sans and some serif, I'm totally fine with that. Just as long as it's not an oversight! |
Resolved in #373 |
I forget where we landed on using serif vs. sans Chinese characters but seem to recall @thatbudakguy leaning toward serif? Whichever direction we go, they should be uniform, right?
Currently, figures 3, 4, and 6 use serif, and figures 2 and 7 use sans.
The text was updated successfully, but these errors were encountered: