Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some figures use serif CJK, others use sans #367

Closed
gwijthoff opened this issue Sep 27, 2023 · 5 comments · Fixed by #373
Closed

Some figures use serif CJK, others use sans #367

gwijthoff opened this issue Sep 27, 2023 · 5 comments · Fixed by #373
Assignees
Labels
chore One-off task

Comments

@gwijthoff
Copy link
Contributor

I forget where we landed on using serif vs. sans Chinese characters but seem to recall @thatbudakguy leaning toward serif? Whichever direction we go, they should be uniform, right?

Currently, figures 3, 4, and 6 use serif, and figures 2 and 7 use sans.

@gwijthoff gwijthoff added the bug Something isn't working label Sep 27, 2023
@rlskoeser rlskoeser removed the bug Something isn't working label Sep 28, 2023
@rlskoeser
Copy link
Contributor

@gwijthoff Gissoo designed them (or at least some of them) to use sans serif because she wanted it to be more readable. Nick wanted to switch some of them to serif because it was representing historical content. It seems ok to me for them to be different if they are serving different purposes, but I defer to @thatbudakguy on that.

I know he had planned to open a PR with an update to change the ones he wanted updated, but I've lost track whether that's been done.

@thatbudakguy
Copy link
Collaborator

it has not been done, but I want to – sorry! maybe today.

@rlskoeser
Copy link
Contributor

@thatbudakguy if you tell me which figures / or portions or remind me if you already made a note of this somewhere I'll see if I can get to it today.

@gwijthoff
Copy link
Contributor Author

If the intent is to have some sans and some serif, I'm totally fine with that. Just as long as it's not an oversight!

@gwijthoff
Copy link
Contributor Author

Resolved in #373

@rlskoeser rlskoeser added the chore One-off task label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore One-off task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants