chore: update to nex-go v2 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItzSwirlz
changed the title
ItzSwirlz
commented
Jul 23, 2024
| @@ -27,7 +27,7 @@ func connectMongo() { | |||
| mongoContext, _ = context.WithTimeout(context.Background(), 10*time.Second) | |||
| _ = mongoClient.Connect(mongoContext) | |||
|
|
|||
| accountDatabase = mongoClient.Database("pretendo") | |||
| accountDatabase = mongoClient.Database("pretendo_account") | |||
There was a problem hiding this comment.
This is what the self-hosted pretendo server was using for its DB name, so I just set it to this. I'm assuming that's what it actually is called. Do we need an environment variable for this?
| @@ -8,7 +8,7 @@ import ( | |||
| "go.mongodb.org/mongo-driver/mongo/options" | |||
| ) | |||
|
|
|||
| func GetCallInfoByTarget(target uint32) (uint32, uint32, bool) { // caller pid, target pid, ringing | |||
| func GetCallInfoByTarget(target uint64) (uint64, uint64, bool) { // caller pid, target pid, ringing | |||
There was a problem hiding this comment.
I moved to this because PIDs use uint64
| } | ||
|
|
||
| // The user must be kicked, otherwise the app hangs forever. | ||
| globals.NEXServer.TimeoutKick(client) | ||
| // globals.NEXServer.TimeoutKick(client) |
There was a problem hiding this comment.
This is the only area of concern about this PR. How to handle the timeout kick.
| fmt.Println("======================") | ||
| }) | ||
|
|
||
| // * Register the common handlers first so that they can be overridden if needed | ||
| registerCommonProtocols() | ||
| registerNEXProtocols() | ||
|
|
||
| globals.NEXServer.Listen(":60005") | ||
| globals.SecureServer.Listen(60005) |
There was a problem hiding this comment.
I would env variable this but I'd rather wait until we merge the authentication repo in here since it also uses the port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3
Changes:
Update to nex-go v2.0
Now uses the nex-protocols-common-go implementations of the Match Making, Match Making Ext and Match Make Extension protocol (along with the servers own handler methods)
Requires the new environment variable
PN_WIIU_CHAT_KERBEROS_PASSWORDUses GRPC for account authentication. This comes with its respective environment variables
I have read and agreed to the Code of Conduct.
I have read and complied with the contributing guidelines.
What I'm implementing was an approved issue.
I have tested all of my changes.
Testing this locally will require some rigging to wiiu-chat-authentication (switching it to the ticket-granting protocol) for it to work. I don't have more than one Wii U, but I was able to get into the main Wii U Chat menu.