Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate improvements for user authentication forms #582

Closed
kpodemski opened this issue Jan 26, 2024 · 5 comments
Closed

Incorporate improvements for user authentication forms #582

kpodemski opened this issue Jan 26, 2024 · 5 comments

Comments

@kpodemski
Copy link
Contributor

More details:
https://evilmartians.com/chronicles/html-best-practices-for-login-and-signup-forms

Details to be specified.

@yannicka
Copy link
Contributor

yannicka commented Feb 2, 2024

For the first point, here is the current state (and in brackets what I propose):

Login

  • Email: autocomplete="email" (=> autocomplete="username")
  • Password: autocomplete="current-password" (=> keep the same value)

Registration

  • Email: nothing (=> autocomplete="username")
  • Password: nothing (=> autocomplete="new-password")

Forgotten password

Ask email scren

  • Email: nothing (=> autocomplete="username")

New password screen

  • New password: nothing (=> autocomplete="new-password")
  • Repeat password: nothing (=> autocomplete="new-password")

Identity

  • Email: autocomplete="off" (=> autocomplete="username")
  • Current password: nothing (=> autocomplete="off" OR autocomplete="current-password")
  • New password: autocomplete="off" (=> autocomplete="new-password" OR keep the same value off)

Is it any good? I'm not sure which is preferable between "username" and "email".

@yannicka
Copy link
Contributor

yannicka commented Feb 2, 2024

Points 2, 3, 4, 5, 6, 7 and 9 seem good.

Point 8 ("Mark invalid fields for screen-readers") is not good.

I don't know about points 10 and 11.

I haven't checked in detail, but here's what emerges from a (very) quick analysis.

@kpodemski
Copy link
Contributor Author

Hello @yannicka

I'm not sure which is preferable between "username" and "email".

I think it would be email, and from what I remember this was the main improvement I wanted to include to forms in Hummingbird.

I don't know about points 10 and 11.

10 - I think we're good. 11 - this is worth checking, every single action that takes time and is being sent via AJAX should indicate that something is going on, I think it works better in Hummingbird but I haven't checked everything

@yannicka
Copy link
Contributor

yannicka commented Feb 8, 2024

So:

@yannicka
Copy link
Contributor

yannicka commented Feb 8, 2024

We can also go a little further with the other autocomplete values for the first name, surname, address, postcode, telephone number, etc. (on PrestaShop code)

@tblivet tblivet mentioned this issue Jun 6, 2024
@tblivet tblivet closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants