Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize COMMON_APP_CONFIG structure for better readability——src/environment.ts #433

Open
ChZhangLang opened this issue Nov 4, 2024 · 0 comments

Comments

@ChZhangLang
Copy link

在 COMMON_APP_CONFIG 的定义中,使用了一个对象 variables 来存储 GitHub 相关的常量。为了提高代码的维护性,建议将这些常量独立出来,直接使用常量名称。这将简化代码结构。

建议修改:
将 variables 对象中的常量提取为独立的常量,例如 GITHUB_ORGANIZATION_NAME 和 GITHUB_PROJECT_NAME。
直接在 COMMON_APP_CONFIG 中引用这些常量,避免中间对象的使用。
这样的修改将提升代码的清晰度,并方便未来的维护。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant