You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is this repository accepting community PRs? If so, please consider adding a CONTRIBUTING.md file or instructions in the README to guide community members toward making fruitful contributions ^.^ . Some questions worth answering:
What is the quality bar required for a contribution to be accepted? (i.e. does it need to be well tested?)
Is there a community code of conduct?
Should community members open an issue to get feedback from maintainers before submitting a PR, to ensure their feature addition is likely to be accepted?
It wouldn't take much to improve the surface area of the library. For example, I'm running an Axum webserver, which requires an async runtime. This library doesn't seem to work in an async context because the blocking client drops a held runtime, which isn't allowed. It would be possible to fix this by using a non-blocking reqwest client.
The text was updated successfully, but these errors were encountered:
Hello!
Is this repository accepting community PRs? If so, please consider adding a CONTRIBUTING.md file or instructions in the README to guide community members toward making fruitful contributions ^.^ . Some questions worth answering:
It wouldn't take much to improve the surface area of the library. For example, I'm running an Axum webserver, which requires an async runtime. This library doesn't seem to work in an async context because the blocking client drops a held runtime, which isn't allowed. It would be possible to fix this by using a non-blocking reqwest client.
The text was updated successfully, but these errors were encountered: