Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepting Community PRs? #6

Open
3 tasks
RobbieMcKinstry opened this issue Jun 13, 2023 · 4 comments
Open
3 tasks

Accepting Community PRs? #6

RobbieMcKinstry opened this issue Jun 13, 2023 · 4 comments

Comments

@RobbieMcKinstry
Copy link

RobbieMcKinstry commented Jun 13, 2023

Hello!

Is this repository accepting community PRs? If so, please consider adding a CONTRIBUTING.md file or instructions in the README to guide community members toward making fruitful contributions ^.^ . Some questions worth answering:

  • What is the quality bar required for a contribution to be accepted? (i.e. does it need to be well tested?)
  • Is there a community code of conduct?
  • Should community members open an issue to get feedback from maintainers before submitting a PR, to ensure their feature addition is likely to be accepted?

It wouldn't take much to improve the surface area of the library. For example, I'm running an Axum webserver, which requires an async runtime. This library doesn't seem to work in an async context because the blocking client drops a held runtime, which isn't allowed. It would be possible to fix this by using a non-blocking reqwest client.

@joshua-mo-143
Copy link

I'm also interested in contributing. PostHog is a great product but an incomplete Rust SDK degrades the experience somewhat.

@djmango
Copy link

djmango commented Apr 19, 2024

+1

@joshua-mo-143
Copy link

I found out that you can generate an OpenAPI client library using the OpenAPI generator as Posthog has an OpenAPI spec.

For other things, Shuttle has a fork of posthog-rs that includes an async client: https://github.com/shuttle-hq/posthog-rs

@louis030195
Copy link

louis030195 commented Jul 30, 2024

i wish this SDK was more complete too!

atm i just prefer doing raw request myself in https://github.com/louis030195/screen-pipe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants