From 18666ea6a11c3715fd3b077939426e9d37136383 Mon Sep 17 00:00:00 2001
From: dylan <dylan@posthog.com>
Date: Wed, 24 Jul 2024 12:46:18 -0700
Subject: [PATCH 1/2] oops

---
 src/extensions/surveys/components/QuestionTypes.tsx | 10 +++++++++-
 src/posthog-surveys-types.ts                        |  2 +-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/src/extensions/surveys/components/QuestionTypes.tsx b/src/extensions/surveys/components/QuestionTypes.tsx
index c2a829658..3d16d834e 100644
--- a/src/extensions/surveys/components/QuestionTypes.tsx
+++ b/src/extensions/surveys/components/QuestionTypes.tsx
@@ -158,7 +158,14 @@ export function RatingQuestion({
                             className="rating-options-number"
                             style={{ gridTemplateColumns: `repeat(${scale - starting + 1}, minmax(0, 1fr))` }}
                         >
-                            {(question.scale === 5 ? fiveScaleNumbers : tenScaleNumbers).map((number, idx) => {
+                            {(question.scale === 5
+                                ? fiveScaleNumbers
+                                : question.scale === 7
+                                ? sevenScaleNumbers
+                                : question.scale === 10
+                                ? tenScaleNumbers
+                                : fiveScaleNumbers
+                            ).map((number, idx) => {
                                 const active = rating === number
                                 return (
                                     <RatingButton
@@ -369,4 +376,5 @@ export function MultipleChoiceQuestion({
 const threeScaleEmojis = [dissatisfiedEmoji, neutralEmoji, satisfiedEmoji]
 const fiveScaleEmojis = [veryDissatisfiedEmoji, dissatisfiedEmoji, neutralEmoji, satisfiedEmoji, verySatisfiedEmoji]
 const fiveScaleNumbers = [1, 2, 3, 4, 5]
+const sevenScaleNumbers = [1, 2, 3, 4, 5, 6, 7]
 const tenScaleNumbers = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
diff --git a/src/posthog-surveys-types.ts b/src/posthog-surveys-types.ts
index c1e94c647..9dbc4e63e 100644
--- a/src/posthog-surveys-types.ts
+++ b/src/posthog-surveys-types.ts
@@ -70,7 +70,7 @@ export interface LinkSurveyQuestion extends SurveyQuestionBase {
 export interface RatingSurveyQuestion extends SurveyQuestionBase {
     type: SurveyQuestionType.Rating
     display: 'number' | 'emoji'
-    scale: number
+    scale: 3 | 5 | 7 | 10
     lowerBoundLabel: string
     upperBoundLabel: string
 }

From 62f4536d33670c14b065796e1f0b2ba472d227b7 Mon Sep 17 00:00:00 2001
From: dylan <dylan@posthog.com>
Date: Wed, 24 Jul 2024 14:03:18 -0700
Subject: [PATCH 2/2] replace ternary with a function call

---
 .../surveys/components/QuestionTypes.tsx      | 22 ++++++++++++-------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/src/extensions/surveys/components/QuestionTypes.tsx b/src/extensions/surveys/components/QuestionTypes.tsx
index 3d16d834e..4897a4eb2 100644
--- a/src/extensions/surveys/components/QuestionTypes.tsx
+++ b/src/extensions/surveys/components/QuestionTypes.tsx
@@ -158,14 +158,7 @@ export function RatingQuestion({
                             className="rating-options-number"
                             style={{ gridTemplateColumns: `repeat(${scale - starting + 1}, minmax(0, 1fr))` }}
                         >
-                            {(question.scale === 5
-                                ? fiveScaleNumbers
-                                : question.scale === 7
-                                ? sevenScaleNumbers
-                                : question.scale === 10
-                                ? tenScaleNumbers
-                                : fiveScaleNumbers
-                            ).map((number, idx) => {
+                            {getScaleNumbers(question.scale).map((number, idx) => {
                                 const active = rating === number
                                 return (
                                     <RatingButton
@@ -378,3 +371,16 @@ const fiveScaleEmojis = [veryDissatisfiedEmoji, dissatisfiedEmoji, neutralEmoji,
 const fiveScaleNumbers = [1, 2, 3, 4, 5]
 const sevenScaleNumbers = [1, 2, 3, 4, 5, 6, 7]
 const tenScaleNumbers = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
+
+function getScaleNumbers(scale: number): number[] {
+    switch (scale) {
+        case 5:
+            return fiveScaleNumbers
+        case 7:
+            return sevenScaleNumbers
+        case 10:
+            return tenScaleNumbers
+        default:
+            return fiveScaleNumbers
+    }
+}