Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an error if externalService is used without service.enabled being false #318

Closed
macobo opened this issue Mar 3, 2022 · 1 comment · Fixed by #319
Closed

Raise an error if externalService is used without service.enabled being false #318

macobo opened this issue Mar 3, 2022 · 1 comment · Fixed by #319
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@macobo
Copy link
Contributor

macobo commented Mar 3, 2022

Proposed change

If service.enabled is true, externalService values are ignored. This can cause errors due to typos.

We should raise errors for example externalClickhouse.host is set but clickhouse.host is not.

Alternative options

Let users debug

Additional context

Ran into this doing #279 - typos are inevitable!

We can use a similar system to our current backwards incompatibility errors.
@macobo macobo added enhancement New feature or request good first issue Good for newcomers labels Mar 3, 2022
@aaronandrino aaronandrino mentioned this issue Mar 4, 2022
Merged
6 tasks
@aaronandrino
Copy link
Contributor

Hey @macobo, let me know if #319 solves this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Raise errors if both externalService and service are set
2 participants
@macobo @aaronandrino