Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: building failed by undeclared variables in cypher_analyze.c #1079

Open
1 task done
xiechuanjie opened this issue Oct 8, 2024 · 6 comments
Open
1 task done
Labels
bug Something isn't working documentation Improvements or additions to documentation question Further information is requested

Comments

@xiechuanjie
Copy link

What is your question?

I am evaluating the possibility to extend the PolyhedralSurface geometry type in postgraph, in order to store BIM (building Information modeling) graph. But source code make failed by undeclared variables in cypher_analyze.c, The erros are "parse_hook,parse_analyze_hook,create_command_tag_hook" being undeclared variables in cypher_analyze.c.I also can't find above three variables in postgres headers. Please help!

Contact Details

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@xiechuanjie xiechuanjie added the bug Something isn't working label Oct 8, 2024
@JoshInnis JoshInnis added documentation Improvements or additions to documentation question Further information is requested labels Oct 8, 2024
@JoshInnis
Copy link
Contributor

JoshInnis commented Oct 8, 2024

Hello,

So this project is undergoing a lot of changes right now and its not in the most usable condition, sorry about that.

This version of PostGraph is using a modified version of Postgres. The thesis being that with a feel small additions to Postgres, you can add a new query language. *EDIT: and storage engine

You can find the modified version of Postgres here. https://github.com/PostGraphDB/postgres_for_postgraph

I also made a branch from the project before I added these new hooks, https://github.com/PostGraphDB/postgraph/tree/old_main. You can take a look while I get the main branch to a workable state

@JoshInnis
Copy link
Contributor

Sidenote: the PostGIS integration is not done, if you need specific functions, ask me and I will add them, that part is relatively simple and does not take a large amount of time

@xiechuanjie
Copy link
Author

@JoshInnis Thank you very much for your prompt reply, my suggestion is to add the 3D data type PolyhedralSurface for postgraph , which will help a lot in storing 3D data graph for architecture (such as BIM). Thanks again!

@JoshInnis
Copy link
Contributor

The base data type is supported. I added a test case to confirm it. The functions are not there yet, I'll try to do those tomorrow. I assume you want the index support too? That will take a little while longer.

@JoshInnis
Copy link
Contributor

It was a longer day at work than expected. I supported most of the PostGIS regression cases for PolyhedralSurface, but couldn't do them all.

I'll keep adding more, I need a break from reconciling the PostGraph and Postgres lexar anyways.

@xiechuanjie
Copy link
Author

@JoshInnis Thank you very much for your hard work, if it becomes available I will immediately carry out application testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants