Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

header class for headers that are not <h2> #75

Closed
wants to merge 1 commit into from
Closed

Conversation

valdrinkoshi
Copy link
Member

Fixes #35, fixes #21 by avoiding the setting of margin, padding for the element with header class.
Also, made styles specific enough not to be overridden by something as simple as

<style is="custom-style">
  h2 {
    margin: 0;
    padding: 0;
  };
</style

Use case for #35: paper-toolbar has a background color and buttons on the left/right, and it handles padding itself, so it should use this class when used in a paper-dialog like this

<paper-dialog>
  <paper-toolbar class="header">
    <div class="title">Header</div>
  </paper-toolbar>
  <div>Content</div>
</paper-dialog>

@@ -21,26 +21,25 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN
@apply(--paper-dialog);
}

:host > ::content > * {
:host > ::content > *:not(.header):not(.buttons) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sorvell says that this is bad news bears (it's really slow, not to mention very deprecated in shadow DOM v1), so I don't think this is a good change. :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, in light of this, should we deprecate these styles already?

@valdrinkoshi
Copy link
Member Author

Closing this, as it makes the styles slower.

@valdrinkoshi valdrinkoshi deleted the issue-35 branch April 17, 2017 22:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants