Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why two classes PMLinearCongruentialRandomGenerator and PMCongruentialRandomNumberGenerator? #219

Open
SergeStinckwich opened this issue Aug 9, 2021 · 0 comments

Comments

@SergeStinckwich
Copy link
Member

SergeStinckwich commented Aug 9, 2021

There are two classes that looks quite similar: PMLinearCongruentialRandomGenerator (subclass of Object) and PMCongruentialRandomNumberGenerator (subclass of PMPseudoRandomNumberGenerator). Apparently the first one is coming from DHB book, the origin of the second is unclear. We should find a way to combine them in one class in the PMCongruentialRandomNumberGenerator class hierarchy.

Same problem with PMMitchellMooreGenerator who is a subclass of Object and not PMPseudoRandomNumberGenerator.

Same problem with PMMarsagliaKissRandomKernel who is a subclass of Object and PMMarsagliaKissRandomKernel a subclass of PMPseudoRandomNumberGenerator.

@SergeStinckwich SergeStinckwich changed the title Why two classes PMLinearCongruentialRandomGenerator and PMCongruentialRandomNumberGenerator Why two classes PMLinearCongruentialRandomGenerator and PMCongruentialRandomNumberGenerator? Aug 9, 2021
@SergeStinckwich SergeStinckwich changed the title Why two classes PMLinearCongruentialRandomGenerator and PMCongruentialRandomNumberGenerator? Why two classes PMLinearCongruentialRandomGenerator and PMCongruentialRandomNumberGenerator? Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant