Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add María to team page #2389

Merged
merged 6 commits into from
Mar 7, 2025
Merged

Add María to team page #2389

merged 6 commits into from
Mar 7, 2025

Conversation

juaristi22
Copy link
Contributor

Fix #2377

@Copilot Copilot bot review requested due to automatic review settings March 4, 2025 14:40
Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
policyengine-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 7:05pm

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds María to the team page by introducing a new staff member entry in the staff data file.

  • Introduces a new key for María with her name, bio, and associated image.
  • Adds corresponding image reference in the staff data.

Reviewed Changes

File Description
src/data/staff.js Added María Juaristi entry with bio and image

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/data/staff.js:81

  • [nitpick] The multi-line template literal for the bio may include unintended whitespace or newline characters due to the indentation. Consider aligning the content or using string concatenation to ensure consistent formatting.
    bio: `is a policy modeling intern at PolicyEngine.  She is also pursuing an

bio: `is a policy modeling intern at PolicyEngine. She is also pursuing an
undergraduate degree in Political Science and Data Science at Minerva University.
Previously, she was a research intern at University of Chicago.`,
image: require("../images/authors/maria-juaristi.JPG"),
Copy link
Preview

Copilot AI Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image file extension 'JPG' differs from the lowercase convention used elsewhere. If the actual file is named with lowercase, update the extension to '.jpg' to avoid potential issues on case-sensitive systems.

Suggested change
image: require("../images/authors/maria-juaristi.JPG"),
image: require("../images/authors/maria-juaristi.jpg"),

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@anth-volk
Copy link
Collaborator

@juaristi22 Is this finalized? If so, can review today.

Copy link
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @juaristi22! Just a couple minor recommended changes, then we'll be good to merge.

Copy link
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juaristi22!

@anth-volk anth-volk merged commit ec60c73 into PolicyEngine:master Mar 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Maria to team page
2 participants