Point reproduce in Python segments to HuggingFace URLs #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anth-volk
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Hey @nikhilwoodruff, thanks for this quick turnaround. My main thought is in my comment below, but TL;DR, would it be more logical (and equally as fast) to solve this in us-data? Looking forward to your thoughts.
Add NYC appendix for WFTC
anth-volk
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Based on conversation with @nikhilwoodruff, I think this is good to go, as we will re-enable simpler dataset loading with the inclusion of policyengine.py within the API. @nikhilwoodruff if you could lint this, it should be good to merge!
…ngine/policyengine-app into nikhilwoodruff/issue2315
|
@nikhilwoodruff I've taken the liberty of linting in order to get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2315
Description
Point dataset strings to URLs instead
Changes
As above.
Screenshots
No tests added.