Duplicate definition of the /simulations route

[mikesmit]

in policyengine_api/app.py there are two identical route definitions:

app.route("/simulations", methods=["GET"])(get_simulations)

app.route("/simulations", methods=["GET"])(get_simulations)

[mikesmit]

I am picking this up as an easy first contribution. Reaching out to request contributor access as per the README

[mikesmit]

Confirmed that removing one of the two lines does not stop the service from responding to curl http://127.0.0.1:5000/simulations with a valid JSON response.

Removing both results in a 404 error.

[mikesmit]

Code is ready, but make debug-test is failing with

dataset.py:308: in download
    raise ValueError(
E   ValueError: Invalid response code 404 for url https://api.github.com/repos/PolicyEngine/ukda/releases/tags/1.9.0.

Reached out on slack to see what the deal with that is (unrelated to my change I'm 99% sure)

[mikesmit]

Confirmed the test error is unrelated to my change and submitted make debug-test fails with 404 error #1954 to track.

[mikesmit]

put in pull request