Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update location typeahead response to accommodate data source map #577

Open
joshuagraber opened this issue Jan 10, 2025 · 2 comments
Open
Assignees
Labels
api enhancement New feature or request

Comments

@joshuagraber
Copy link
Contributor

Context

As we're working on the data source map, it would be ideal to get more location data with our location data 😅

Requirements

  • Is it possible to get latitude and longitude (lat, lng) data for location objects? I know we have this data for data sources, but not sure if it's in the DB for location objects themselves.
  • If not, the client has some options. But this would be the ideal situation.

Tests

  • Any changes should be represented in tests

Docs

  • Any changes should be represented in docs and Swagger

Open questions

It's all uncertain.

@joshuagraber
Copy link
Contributor Author

joshuagraber commented Jan 10, 2025

Hey @maxachis Here's an issue to start chopping it up about the maps updates. I may need to request one more update, but I think this will be it.

@joshuagraber joshuagraber added enhancement New feature or request api labels Jan 11, 2025
@maxachis maxachis pinned this issue Jan 14, 2025
@maxachis
Copy link
Contributor

maxachis commented Jan 23, 2025

@joshuagraber Finally got around to looking at this!

One challenge we have is that latitude and longitude are currently associated with agencies in the database and not with locations, and between 1/4th and 1/5th of agencies do not have latitudes or longitudes. Additionally, some agencies share the same location and differ in their reported latitude and longitudes.

This could (and should!) be resolved, but it'll probably be hard to do until after #456: the schema has changed too much from Prod v1 to be able to insert the data at the source-of-truth point of the prod v1 database, and inserting that data after every production/stage migration wouldn't be practical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants