Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance followed searches to include record_category #567

Open
3 tasks
josh-chamberlain opened this issue Dec 19, 2024 · 1 comment
Open
3 tasks

Enhance followed searches to include record_category #567

josh-chamberlain opened this issue Dec 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@josh-chamberlain
Copy link
Contributor

Context

We currently capture the location of a followed search; however, someone could create a search for a location and filter by record category. They could reasonably expect that following a search would include only the selected categories.

Screen Shot 2024-12-19 at 12 55 14 PM

Requirements

  • update POST /search/follow to accept record_categories
  • update GET /search/follow to return record_categories followed for a given search
    • GET /user/recent-searches works like this currently
  • the front end can then include this as wireframed

Tests

I defer.

@josh-chamberlain josh-chamberlain added the v2 For v2 release label Dec 19, 2024
@josh-chamberlain josh-chamberlain added enhancement New feature or request and removed v2 For v2 release labels Dec 19, 2024
@josh-chamberlain josh-chamberlain moved this from Todo to Future in Open issues & Roadmap Dec 19, 2024
@josh-chamberlain
Copy link
Contributor Author

josh-chamberlain commented Dec 19, 2024

Per @maxachis: Updated follows is simple enough, but this also will require adjusting the notifications architecture, which was designed to pull only on subscribed locations. This is probably a 1–2 day issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Future
Development

No branches or pull requests

2 participants