Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetFilter adds incorrect keys #44

Open
Iiminalspace opened this issue Apr 27, 2024 · 0 comments · May be fixed by #45
Open

SetFilter adds incorrect keys #44

Iiminalspace opened this issue Apr 27, 2024 · 0 comments · May be fixed by #45

Comments

@Iiminalspace
Copy link

SetFilterBuilder.CreateSetFilter().AddPtcgoCode("PTCGO_CODE") produces {"PtcgoCode", "PTCGO_CODE"} as KVP. Because the first letter is capitalized, the query will fail to find when passed to the client.

Manually adding filter.Add("ptcgoCode", "PTCGO_CODE") will work as temporary workaround.

SetFilter.AddName() and SetFilter.AddSeries() have the same issue.
@Iiminalspace Iiminalspace linked a pull request Apr 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SetFilter key generation Iiminalspace/pokemon-tcg-sdk-csharp
1 participant
@Iiminalspace