[apps] Convert macro to lambda and fix the call-sites

[kunaltyagi]

Convert macro FPS_CALC to lambda and fix the call-sites.

Locations:

• apps/include/pcl/apps/manual_registration.h
• apps/include/pcl/apps/openni_passthrough.h
• apps/include/pcl/apps/pcd_video_player.h
• apps/include/pcl/apps/timer.h

Originally posted by @kunaltyagi in #3885

[SunBlack]

There are much more of it:

• pcl\apps\include\pcl\apps\manual_registration.h
• pcl\apps\include\pcl\apps\openni_passthrough.h
• pcl\apps\include\pcl\apps\organized_segmentation_demo.h
• pcl\apps\include\pcl\apps\pcd_video_player.h
• pcl\apps\include\pcl\apps\timer.h
• pcl\apps\src\openni_3d_concave_hull.cpp
• pcl\apps\src\openni_3d_convex_hull.cpp
• pcl\apps\src\openni_boundary_estimation.cpp
• pcl\apps\src\openni_color_filter.cpp
• pcl\apps\src\openni_fast_mesh.cpp
• pcl\apps\src\openni_feature_persistence.cpp
• pcl\apps\src\openni_grab_frame.cpp
• pcl\apps\src\openni_ii_normal_estimation.cpp
• pcl\apps\src\openni_klt.cpp
• pcl\apps\src\openni_mls_smoothing.cpp
• pcl\apps\src\openni_octree_compression.cpp
• pcl\apps\src\openni_organized_compression.cpp
• pcl\apps\src\openni_uniform_sampling.cpp
• pcl\apps\src\openni_voxel_grid.cpp

Just care: Not all are completely equal

[chaytanyasinha]

@kunaltyagi May I do this?

[SunBlack]

After #3885 is merged - yes ;-)

[chaytanyasinha]

@SunBlack I didn't knew you were already working on it.

[SunBlack]

No, I'm not working on it. I'm just applying clang-format to apps and during this we detected this code duplication. But it makes no sense to work on it, as long the formatting is not merged, as you would get a big merge conflict.

[chaytanyasinha]

@SunBlack Okay.

[stale]

Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.

[kunaltyagi]

#3885 is now merged, and this issue is open for action