Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect if page is already saved and highlight icon #209

Open
alexkrolick opened this issue May 31, 2020 · 3 comments
Open

Detect if page is already saved and highlight icon #209

alexkrolick opened this issue May 31, 2020 · 3 comments

Comments

@alexkrolick
Copy link

Expected Behavior

Feature request: if a page is already saved in Pocket, use the Saved Article state for the address bar icon (ie red instead of gray); or, at least detect the duplicate at save time and warn about it

Actual Behavior

When coming back to a page that I already saved, the icon is the standard gray color, so I sometimes save the page again and create duplicates

Specifications

  • Version: All
  • Browser: All
  • Operating System: All
@collectedmind
Copy link
Contributor

@alexkrolick The main challenge here is using bandwidth behind the scenes without intent. With mild usage this would have less of an impact. Over time we would be making a request on every tab opened and it would start to add up for the user in terms of bandwidth impact. The other side of the coin are extremely large lists and downloading that data to the users computer would start to eat up memory without intent.

I do agree this would be an excellent addition to the extension, so perhaps we can find some middle ground here.

@alexkrolick
Copy link
Author

alexkrolick commented Sep 16, 2020

The mobile appears to be able to detect this. It says something like "This page is already saved. Moving it to the top of your queue." What's the difference with the extension?

EDIT:
I am guessing the mobile app uses the offline store to look it up. That's a separate app on desktop. I could see either unifying the functionality such that the extension also installs a PWA version of the app, or can detect if the desktop app is installed and communicate with it via protocol links. Both of these approaches are taken by password managers.

@collectedmind
Copy link
Contributor

@alexkrolick Yep! It is the case that the mobile apps use an offline store. We have spoken about ways to implement this on web/extension and I think there's some options to explore. I have played around this idea with web-workers and IndexedDB (which presented some additional challenges due to the nature of extensions and IndexedDB support).

All in all this is something that I think would make a good addition and as we start to revisit and prioritize I will keep this in the hopper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants