Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify wallet mocks: it does not matter which one is in effect #1526

Open
klntsky opened this issue Aug 9, 2023 · 0 comments
Open

Unify wallet mocks: it does not matter which one is in effect #1526

klntsky opened this issue Aug 9, 2023 · 0 comments
Labels
CIP-30 CIP-30 interface e2e testing End-to-end browser testing

Comments

@klntsky
Copy link
Member

klntsky commented Aug 9, 2023

The E2E test suite does not distinguish between MockNami, MockGero, etc.

Initially we thought that we could implement different behaviors in mocks in the future, but it turned out we don't need them to be different (and we can't really guarantee that mocks are identical to the implementations).
@klntsky klntsky added e2e testing End-to-end browser testing CIP-30 CIP-30 interface labels Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CIP-30 CIP-30 interface e2e testing End-to-end browser testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@klntsky