Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Inspect on LOWEST priority #663

Open
JHarris12345 opened this issue Oct 31, 2024 · 11 comments
Open

Core Inspect on LOWEST priority #663

JHarris12345 opened this issue Oct 31, 2024 · 11 comments

Comments

@JHarris12345
Copy link

JHarris12345 commented Oct 31, 2024

I think the /co i for the armor stand / item frame lookups should be on the LOWEST priority instead of MONITOR. Other plugins that do things on the PlayerInteractEvent etc are going about their business ahead of CoreProtect which prevents look ups (say you're trying to look up player interactions on an armor stand but the player doesn't have permission to modify them)

@Skullians
Copy link

it being on monitor is the point, highest priority meaning the event is called last. This means plugins can do stuff related to the events it listens to such as cancel, modify etc before CoreProtect logs it

@Skullians
Copy link

CoreProtect won’t log things if the event was cancelled

@JHarris12345
Copy link
Author

You haven't understood this at all. This isn't about logging. It's about looking up. If I try to use /co i to view transaction on an armor stand, it gets cancelled by the claiming plugin before core protect looks it up

@JHarris12345
Copy link
Author

@Skullians view this vide. See how I can't look up armor stand transactions because the lookup is on the same priority as the log (MONITOR). The lookup needs to be in a different listener and on LOWEST (just like player interact lookups are)

2024-10-31.11-37-58.mp4

@Skullians
Copy link

OH you mean the inspect feature

@JHarris12345
Copy link
Author

Yah that's what I said in the original message and the title xD

@Skullians
Copy link

Right, apologies, didn’t read your message properly.
In all honesty if you have co perms you should also have permission to bypass claims, but up to you.
Will wait for Intelli to see this (@Intelli), otherwise you’ll either have to wait, fork the code and change the priority yourself, or bypass claims

@JHarris12345
Copy link
Author

I give my players lookup perms so definitely can't do that

@Skullians
Copy link

Huh… interesting

@Skullians
Copy link

Then yeah all you can do is fork the code or wait

Copy link

stale bot commented Dec 31, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 31, 2024
@Intelli Intelli removed the stale label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants