Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property 'response' does not exist on type 'ModifyDonations'. #1868

Open
prachigarg19 opened this issue Sep 18, 2023 · 2 comments
Open

Property 'response' does not exist on type 'ModifyDonations'. #1868

prachigarg19 opened this issue Sep 18, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@prachigarg19
Copy link
Collaborator

prachigarg19 commented Sep 18, 2023

Currently a typescript warning Property 'response' does not exist on type 'ModifyDonations'. is present in EditModal.
The issue has not been handled because of no knowledge of the structure of response received when an api request is sent to /app/subscriptions/${record?.id}?scope=modify such that the status received is action_required.

It seems like status=action_required should be received in the cases related to the 2-Factor-Authentication that some cards have or if the card provide has expired in the meantime.

@prachigarg19 prachigarg19 added the bug Something isn't working label Sep 18, 2023
@prachigarg19
Copy link
Collaborator Author

prachigarg19 commented Sep 18, 2023

@mohitb35 : I tried simulating this scenario by using the test stripe card (https://stripe.com/docs/testing#authentication-and-setup) which always needs authentication. After this I modified the amount by a small number and the request was successful. I tried modifying the year/amount by a large number and the request failed with the following 500 error:

"Payment for this subscription requires additional user action before it can be completed successfully. Payment can be completed using the PaymentIntent associated with subscription.latest_invoice. Additional information is available here: https:\/\/stripe.com\/docs\/billing\/subscriptions\/overview#requires-action\nfile: \/app\/vendor\/stripe\/stripe-php\/lib\/Exception\/ApiErrorException.php, line: 38"

@prachigarg19
Copy link
Collaborator Author

@mohitb35 : I tried simulating this scenario by using the test stripe card (https://stripe.com/docs/testing#authentication-and-setup) which always needs authentication. After this I modified the amount by a small number and the request was successful. I tried modifying the year/amount by a large number and the request failed with the following 500 error:

"Payment for this subscription requires additional user action before it can be completed successfully. Payment can be completed using the PaymentIntent associated with subscription.latest_invoice. Additional information is available here: https:\/\/stripe.com\/docs\/billing\/subscriptions\/overview#requires-action\nfile: \/app\/vendor\/stripe\/stripe-php\/lib\/Exception\/ApiErrorException.php, line: 38"

I tried to replicate the same situation and when I edit the amount, the response received still have status active, also even though request status being obtained is 200 there is an error popup with the message : Something went wrong. Please check your internet connection or try again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant