Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obstacle avoider wait until ready #152

Open
asaba96 opened this issue Feb 15, 2019 · 4 comments
Open

Obstacle avoider wait until ready #152

asaba96 opened this issue Feb 15, 2019 · 4 comments

Comments

@asaba96
Copy link
Contributor

asaba96 commented Feb 15, 2019

Obstacle avoider wait until ready should be called in the wait_until_ready method call, not in the constructor, as this delays construction of the topic buffer.

self._obstacle_avoider.wait_until_ready(self._startup_timeout)

@amiller27
Copy link
Member

I feel like there was a reason we put that there (like something else broke if we didn't wait there), but I'm not sure

@aftersomemath
Copy link
Member

The task_topic_buffer's wait_until_ready is dead code. So yes, if the obstacle avoider's wait_until_ready were moved there it would break things.

@amiller27
Copy link
Member

@aftersomemath
Copy link
Member

Github's search is terrible, never again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants