Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add external assets #1

Open
husseinalhammad opened this issue May 7, 2019 · 0 comments
Open

Ability to add external assets #1

husseinalhammad opened this issue May 7, 2019 · 0 comments

Comments

@husseinalhammad
Copy link
Member

At the moment it is not possible to add external assets.

This would be handy when using third-party libraries such as Google Maps API or when loading resources from a CDN. Otherwise you would need to have Pinion add the internal files while you add the markup for the external ones yourself.

Current:

<script src="https://www.google.com/recaptcha/api.js"></script>
<script src="https://maps.googleapis.com/maps/api/js"></script>
<?php perch_get_javascript(['cache-bust' => true]); ?>

Desired is something like:

perch_get_javascript([
    'cache-bust' => true,
    'external' => [
        'https://www.google.com/recaptcha/api.js',
        'https://maps.googleapis.com/maps/api/js'
    ]
]);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant