Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinoccio cmd should accept troop names #15

Open
matthijskooijman opened this issue Jul 31, 2014 · 2 comments
Open

pinoccio cmd should accept troop names #15

matthijskooijman opened this issue Jul 31, 2014 · 2 comments

Comments

@matthijskooijman
Copy link
Collaborator

The pinoccio cmd command currently seems to require using troop and scout ids. There seems to be a few issues here:

  • I'd like to use the troop and scout names in addition to their ids
  • When I use the names (or a non-existing troop), the error message is confusing: {"error":"could not find token for troop 999"}. Instead of suggesting that the troop is unknown, this prompted me to double-check the authentication, see if I had forgotten to manually create a token of some sort, etc.
  • Scout ids (and often also scout names) are, I think, unique among troops, right? If so, there is really no need to specify the troop name or id - that can be deduced from the scout's info?
@soldair
Copy link
Collaborator

soldair commented Aug 1, 2014

there is no constraint but i could message if its violated. ill give it a shot and let you know

@soldair
Copy link
Collaborator

soldair commented Aug 1, 2014

right now i dont make any api calls except the call to execute the command. if the ids are not ints ill make a call to fetch the name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants