Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bansync] Servers that listen to each other cascade bans during softban action #161

Open
EternalllZM opened this issue Dec 21, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@EternalllZM
Copy link

The softban mod action in core's mod causes a cascading ban action effect if two servers listen to each other for bans.

user is softbanned on server 1
ban syncs to server 2
user is unbanned on server 1
user is banned on server 1 again due to ban syncing to server 2 prior to unban syncing

This results in the user being banned from both servers, unbanned from neither.

@PhasecoreX
Copy link
Owner

Interesting, I didn't know what a softban was until now. So I'll need to add some sort of queue or something to make sure each ban or unban event propagates fully before handling the next event.

@PhasecoreX PhasecoreX self-assigned this Dec 21, 2024
@PhasecoreX PhasecoreX added the bug Something isn't working label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants