Removed Credit subplugin

Author: harunaka11037

classes/plugininfo/paymentgateway.php

@@ -95,7 +95,7 @@ public static function sort_gateways_by_order($unsorted) {
 
         foreach ($orderarray as $order => $gatewayname) {
             foreach ($unsorted as $key => $gateway) {
-                if ($gateway->name == $gatewayname) {
+                if ($gateway->get_name() == $gatewayname) {
                     $sorted[] = $gateway;
                     unset($unsorted[$key]);
                 }

paymentgateway/credit/classes/paymentgateway.php

@@ -51,7 +51,7 @@
         get_string('gatewaydisableall:text', 'tool_paymentplugin'), '', 0));
     if ($category == '') {
         foreach ($gateways as $gateway) {
-            $globalsettings->add(new admin_setting_configcheckbox('paymentgateway_'.$gateway->name.'/enabled',
+            $globalsettings->add(new admin_setting_configcheckbox('paymentgateway_'.$gateway->get_name().'/enabled',
                 get_string('gatewayenable:text', 'tool_paymentplugin', $gateway->get_display_name_appended()), '', 0));
         }
     }

paymentgateway/credit/lang/en/paymentgateway_credit.php

@@ -67,17 +67,13 @@ public function test_course_cost() {
     public function test_detectsubplugins() {
         $this->resetAfterTest();
 
-        $gateways = \tool_paymentplugin\plugininfo\paymentgateway::get_all_gateway_objects();
-        // Test gateway detection.
-        $this->assertEquals(2, count($gateways), "The gateway is not detected.");
         // Test disabled by default.
         $this->assertEquals(0, count(\tool_paymentplugin\plugininfo\paymentgateway::get_all_enabled_gateway_objects()),
             "The gateway is not disabled");
 
         // Test enable configs.
         set_config('enabled', 1, 'paymentgateway_paypal');
-        set_config('enabled', 1, 'paymentgateway_credit');
-        $this->assertEquals(2, count(\tool_paymentplugin\plugininfo\paymentgateway::get_all_enabled_gateway_objects()),
+        $this->assertEquals(1, count(\tool_paymentplugin\plugininfo\paymentgateway::get_all_enabled_gateway_objects()),
             "Configs are not enabled.");
 
         // Test disable all config.
@@ -86,11 +82,8 @@ public function test_detectsubplugins() {
             "All configs are not disabled");
 
         set_config('disableall', 0, 'tool_paymentplugin');
-        $this->assertEquals(2, count(\tool_paymentplugin\plugininfo\paymentgateway::get_all_enabled_gateway_objects()),
+        $this->assertEquals(1, count(\tool_paymentplugin\plugininfo\paymentgateway::get_all_enabled_gateway_objects()),
             "All configs are not disabled");
 
-        // Test gateways are not blank.
-        $this->assertEquals($gateways[0]->name, 'credit', "gateway[credit] name is invaild");
-        $this->assertEquals($gateways[1]->name, 'paypal', "gateway[name] name is invaild");
     }
 }