Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how end_time and max_end_time behave #3

Open
PeterJCLaw opened this issue Feb 6, 2021 · 1 comment
Open

Document how end_time and max_end_time behave #3

PeterJCLaw opened this issue Feb 6, 2021 · 1 comment

Comments

@PeterJCLaw
Copy link
Owner

These are very non-obvious to choose.

The alternative would be to make end_time do the more obvious thing, however that would be breaking.

Briefly, within a period schedule:

  • end_time is the latest that a match slot can begin, before any delays are accounted for (and thus determines which matches will attempt to be scheduled as part of the period)
  • max_end_time is the latest a match slow can begin, once delays are accounted for (and thus determines which matches are actually fit into the period)
@PeterJCLaw
Copy link
Owner Author

This was somewhat achieved by PeterJCLaw/dummy-comp@1c264fe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant