Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalise expectations around corner identification #27

Open
PeterJCLaw opened this issue Aug 9, 2023 · 1 comment
Open

Formalise expectations around corner identification #27

PeterJCLaw opened this issue Aug 9, 2023 · 1 comment

Comments

@PeterJCLaw
Copy link
Owner

Currently it is possible to have corners which are numbers that do not start at zero, yet this does not fully work. For Smallpeice 2023 we're going to work around this as we've (@prophile) numbered the corners 1 & 2.

Unfortunately we have quite a few places where we assume that the corners are zero-indexed numbers and that we can trivially map between the index of a team within the list of teams in a match and the corners identities. This also means that the display names of the corners are bound to their ids in a somewhat implicit manner.

@PeterJCLaw
Copy link
Owner Author

Note also that currently SRComp-HTTP appears to be using the "sort keys" functionality of JSON encoding, which sort-of helps here but also masks some potential issues.

PeterJCLaw pushed a commit to PeterJCLaw/srcomp-http that referenced this issue Aug 9, 2023
PeterJCLaw pushed a commit to PeterJCLaw/srcomp-screens that referenced this issue Aug 9, 2023
PeterJCLaw added a commit to PeterJCLaw/srcomp-puppet that referenced this issue Aug 9, 2023
PeterJCLaw added a commit to PeterJCLaw/srcomp-http that referenced this issue Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant