Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Connection" header overwritten by proxy for WS #228

Open
MilanKladivko opened this issue Apr 2, 2022 · 4 comments
Open

"Connection" header overwritten by proxy for WS #228

MilanKladivko opened this issue Apr 2, 2022 · 4 comments

Comments

@MilanKladivko
Copy link

Hello,

I've been trying out the proxy feature to allow seamless integration with my backend hosted locally.
Sadly, I cannot get WS connections to work. Using latest 0.19.0.

When using the proxy in ".nolluprc", the "Connection" header is rewritten from "upgrade" to "close", and my backend rejects it as a websocket protocol violation.
Direct connections do not have this issue.

I am not using HMR or other advanced features, just trying to host the frontend through nollup and not my backend directly...

{
    "contentBase": "./public",
    "proxy": {
        "/": "http://localhost:8100"
    }
}

Is there extra configuration required in ".nolluprc"? Should I look into express-http-proxy options to achieve this?

@MilanKladivko
Copy link
Author

Nevermind, I guess it's not supported by the proxy lib. villadora/express-http-proxy#28

Feel free to close this, I'll just hack it into the frontend itself then.

@PepsRyuu
Copy link
Owner

PepsRyuu commented Apr 2, 2022

This seems like a reasonable thing that should be supported. I'll have a look into it. :)

@PaulRill00
Copy link

Hey, is there any update on this?
I would love to use websockets with this module.

@PepsRyuu
Copy link
Owner

No update on it. Been a very busy few months life-wise! 😅 Probably would have to replace express-http-proxy with something else or somehow manually take care of it. If anyone has additional information on this or suggestions for other proxies to use, happy to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants