Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible error reading StatusBlockWrapper.Tag? #113

Open
rjonkman opened this issue Mar 25, 2023 · 0 comments
Open

Possible error reading StatusBlockWrapper.Tag? #113

rjonkman opened this issue Mar 25, 2023 · 0 comments

Comments

@rjonkman
Copy link
Contributor

rjonkman commented Mar 25, 2023

if(StatusBlockWrapper.Tag != CBWTag) return msProcessError(MS_CSW_TAG_ERROR); // Tag mismatch error

StatusBlockWrapper.Tag is initialized to 0, and then is being updated outside of the scope of this function. Isn't there a chance that the code might store StatusBlockWrapper.Tag in a register (with a value of zero). And then later when it checks if(StatusBlockWrapper.Tag != CBWTag) erroneously report an error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant