Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home and about ui #115

Merged
merged 1 commit into from
May 21, 2024
Merged

home and about ui #115

merged 1 commit into from
May 21, 2024

Conversation

Varsani2520
Copy link
Contributor

pr #93

@PatilHarshh

Related Issue

[Cite any related issue(s) this pull request addresses. If none, simply state "None”]

  • i completed home page ui as well about page ui

Description

[Please include a brief description of the changes or features added]

  • created 2 seperate route for home and about /about and /

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

when i try to attempt deploy your main branch which i re-clone again then also i got 404
but my home and about page are working properly in localhost as well vite preview
i have no access to deploy your web in my vercel account

check this
image

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

@vercel Vercel
Copy link

vercel bot commented May 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kaam-do ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 2:01pm

@github-actions GitHub Actions
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@PatilHarshh
Copy link
Owner

yeah !! now looking Good ! @Varsani2520 . i want certain changes in UI Can you implement now or in another issue ?

@Varsani2520
Copy link
Contributor Author

@PatilHarshh ,
sure i would like to work on that ui improvement
can you please merge this
and let me know what kind of ui improvement you need

@PatilHarshh PatilHarshh merged commit efc725b into PatilHarshh:main May 21, 2024
3 checks passed
@PatilHarshh
Copy link
Owner

mention issue no. @Varsani2520

@PatilHarshh
Copy link
Owner

@PatilHarshh , sure i would like to work on that ui improvement can you please merge this and let me know what kind of ui improvement you need

where should we talk ?

@Varsani2520
Copy link
Contributor Author

@PatilHarshh ,
What ui changes do you want ? if you have any kind of particular ui than please provide me and i can implement in code

@Varsani2520
Copy link
Contributor Author

@PatilHarshh

if you merge my pull request than why i don't see my name in contributation list
if i can't see my name than how i will contribute in another issue
i can only redesign your ui if i can see my name in that list

check this image
image

@PatilHarshh
Copy link
Owner

@PatilHarshh

if you merge my pull request than why i don't see my name in contributation list if i can't see my name than how i will contribute in another issue i can only redesign your ui if i can see my name in that list

check this image image

As i said did you mention issue number here which it closes ?

@Varsani2520
Copy link
Contributor Author

@PatilHarshh

i already closed #71 and create home and about ui
still i can't see my name in contribution list why.???

@Varsani2520
Copy link
Contributor Author

@PatilHarshh ,

as a contributor, my question is why my name is not display in your repositories as a contributor list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
gssoc level3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Varsani2520 @PatilHarshh