Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Required features for Patchouli #99

Open
3 of 15 tasks
ZNixian opened this issue Jun 22, 2020 · 5 comments
Open
3 of 15 tasks

Required features for Patchouli #99

ZNixian opened this issue Jun 22, 2020 · 5 comments
Labels
features needed for mod A list of things needed for a specific Forge mod to work

Comments

@ZNixian
Copy link
Member

ZNixian commented Jun 22, 2020

An in-game book mod, required for quite a few mods including Botania - CurseForge.

As per my issue for Curios, this list is probably not complete. It allowed me to start the game and open the landing page of the 1.15 sample book, however the contents failed to load (probably either because it's a 1.15 book on 1.14, or due to a fault in Patchwork's config implementation - the latter seems fairly likely - see below).

Required features

patchwork-entity-events

  • AdvancementEvent

patchwork-rendering

patchwork-fml

patchwork-gui

  • GuiUtils.preItemToolTip
  • GuiUtils.postItemToolTip
  • GuiUtils.drawHoveringText (specifically, the List, int, int, int, int, int, TextRenderer overload)

Misc:

  • The java3d.vecmath library - this is included with Forge. Version 1.3.1 seems to work fine, though Forge uses 1.5.2 which isn't in Maven Central.
  • MinecraftForgeClient.getLocale must be implemented

Book loading issue

I was having trouble with book entries not showing up. Try setting a breakpoint on BookCategory.getConfigFile if you'd like to investigate.

@ZNixian ZNixian added the features needed for mod A list of things needed for a specific Forge mod to work label Jun 22, 2020
@valoeghese
Copy link
Contributor

Just use the fabric port smh :tiny_potato:

@ZNixian
Copy link
Member Author

ZNixian commented Jun 22, 2020

Oh... that would make it easier.

Any idea how that would interact with something like Botania running under Patchwork?

@valoeghese
Copy link
Contributor

Idk I haven't used either version of the lib

@rikka0w0
Copy link
Contributor

rikka0w0 commented Jun 28, 2020

patchwork-fml:
ModList.getMods and ModContainer.getModInfo are implemented in #87

The implementation of ModelBakeEvent and ModelRegistryEvent require #87 as well.

@rikka0w0
Copy link
Contributor

rikka0w0 commented Sep 8, 2020

#189 implements IModelData

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
features needed for mod A list of things needed for a specific Forge mod to work
Projects
None yet
Development

No branches or pull requests

3 participants