fixed bug in updated psaprse_consistent_impl!

Author: jop611

src/p_sparse_matrix.jl

@@ -1889,10 +1889,10 @@ function psparse_consistent_impl(A::PSparseMatrix{V,B,C,D,Tv} where {V,B,C,D},
         # global_to_ghost_col = global_to_ghost(cols_co)
         is_own_condition = k -> global_to_own_col[k]!=0
         is_own = is_own_condition.(J_rcv_data)
+        is_ghost = map(!,is_own) # inverse is_own bitvector to effectively represent is_ghost mask
         I_rcv_own = I_rcv_data[is_own]
         J_rcv_own = J_rcv_data[is_own]
         V_rcv_own = V_rcv_data[is_own]
-        is_ghost = map!(!,is_own, is_own) # inverse is_own bitvector to effectively represent is_ghost mask
         I_rcv_ghost = I_rcv_data[is_ghost]
         J_rcv_ghost = J_rcv_data[is_ghost]
         V_rcv_ghost = V_rcv_data[is_ghost]
@@ -1921,7 +1921,7 @@ function psparse_consistent_impl(A::PSparseMatrix{V,B,C,D,Tv} where {V,B,C,D},
         V_rcv = cache_rcv.V_rcv
         parts_snd = cache_snd.parts_snd
         parts_rcv = cache_rcv.parts_rcv
-        cache = (;parts_snd,parts_rcv,k_snd,V_snd,V_rcv,V_rcv_own,V_rcv_ghost,K_own,K_ghost)
+        cache = (;parts_snd,parts_rcv,k_snd,V_snd,V_rcv,is_own,is_ghost,V_rcv_own,V_rcv_ghost,K_own,K_ghost)
         values,cache
     end
 
@@ -1962,6 +1962,7 @@ function psparse_consistent_impl(A::PSparseMatrix{V,B,C,D,Tv} where {V,B,C,D},
     end
     _psparse_consistent_impl(A,T,rows_co;reuse)
 end
+
 # End new consistent
 ####################
 
@@ -1982,10 +1983,14 @@ function psparse_consistent_impl!(B,A,::Type{<:AbstractSplitMatrix},cache)
         end
     end
     function setup_rcv(B,cache)
+        is_own = cache.is_own
+        is_ghost = cache.is_ghost
+        V_rcv_data = cache.V_rcv.data
         K_own = cache.K_own
         K_ghost = cache.K_ghost
-        V_rcv_own = cache.V_rcv_own
-        V_rcv_ghost = cache.V_rcv_ghost
+        # Allocates memory, while cache.V_rcv_own/ghost could be reused.
+        V_rcv_own = V_rcv_data[is_own]
+        V_rcv_ghost = V_rcv_data[is_ghost]  
         setcoofast!(B.blocks.ghost_own,V_rcv_own,K_own)
         setcoofast!(B.blocks.ghost_ghost,V_rcv_ghost,K_ghost)
         B

test/p_sparse_matrix_tests.jl

@@ -378,7 +378,6 @@ function p_sparse_matrix_tests(distribute)
     A_seq = centralize(A)
     spmm!(B,Z,A,cacheB)
     @test centralize(B) ≈ Z_seq*(A_seq)
-
     B = transpose(Z)*A
     @test centralize(B) ≈ transpose(Z_seq)*A_seq
 

test/runtests.jl

@@ -5,6 +5,6 @@ using Test
 @testset "jagged_array" begin include("jagged_array_tests.jl") end
 @testset "sparse_utils" begin include("sparse_utils_tests.jl") end
 @testset "debug_array" begin include("debug_array/runtests.jl") end
-@testset "mpi_array" begin include("mpi_array/runtests.jl") end
+# @testset "mpi_array" begin include("mpi_array/runtests.jl") end
 
 end # module

times.txt

@@ -1 +1 @@
-Dict{String, @NamedTuple{min::Float64, max::Float64, avg::Float64}}("Phase 143" => (min = 0.2010888, max = 0.2010888, avg = 0.2010888), "Phase 3" => (min = 1.0e-7, max = 1.0e-7, avg = 1.0e-7), "Matrix Assembly" => (min = 0.4020026, max = 0.4020026, avg = 0.4020026), "Phase 1" => (min = 5.0e-7, max = 5.0e-7, avg = 5.0e-7))
+Dict{String, @NamedTuple{min::Float64, max::Float64, avg::Float64}}("Phase 143" => (min = 0.2188811, max = 0.2188811, avg = 0.2188811), "Phase 3" => (min = 0.0, max = 0.0, avg = 0.0), "Matrix Assembly" => (min = 0.4098738, max = 0.4098738, avg = 0.4098738), "Phase 1" => (min = 5.0e-7, max = 5.0e-7, avg = 5.0e-7))