Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disparity between Eq.(18) in the paper and code implementation #75

Open
cailile opened this issue Sep 2, 2024 · 0 comments
Open

Disparity between Eq.(18) in the paper and code implementation #75

cailile opened this issue Sep 2, 2024 · 0 comments

Comments

@cailile
Copy link

cailile commented Sep 2, 2024

Dear authors, I notice there may be some disparities between Eq.(18) and implementation:

  1. In robust_loss.py, Ln.92, the robust regression loss is implemented as:
image

Compared to what is defined in Eq.(18) of the paper:
image

there is an extra power term **2 on the cs term.

  1. The paper mentioned that c is chosen to be 0.03, but in train_roma_outdoor.py, Ln.220, the value passed to c is 1e-4:
image
  1. The first minus sign in Eq.(18) (indicated by the red circle above) should be removed.

Could you kindly help to clarify? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant