Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a LocalShell API #68

Open
iwanb opened this issue Jun 18, 2021 · 2 comments
Open

Support a LocalShell API #68

iwanb opened this issue Jun 18, 2021 · 2 comments

Comments

@iwanb
Copy link
Contributor

iwanb commented Jun 18, 2021

Hi,

I really like the features you added, but I also use LocalShell from spur to have an API which does not care if it's local or remote but without the overhead of SSH (especially important for file IO).
Would you be willing to add this to spurplus too? It would require moving generic things to a base class (generic over SshShell or LocalShell), and having a second implementation which does things locally instead of through sftp.

Iwan

@mristin
Copy link
Collaborator

mristin commented Jun 19, 2021

Hi @iwanb ,
Thanks for you interest in the project! I am very busy at the moment with the icontract ecosystem, so I won't be able to implement this feature in the near future.

If you'd like, we can try to develop it together where I help you with code reviews and feedback?

@iwanb
Copy link
Contributor Author

iwanb commented Jun 21, 2021

Ok thank you, I will see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants