Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21.3 & 1.21.4] Unable to bulk drop craft #11765

Open
cecilia-sanare opened this issue Dec 22, 2024 · 1 comment · May be fixed by #11831
Open

[1.21.3 & 1.21.4] Unable to bulk drop craft #11765

cecilia-sanare opened this issue Dec 22, 2024 · 1 comment · May be fixed by #11831
Labels
scope: parity status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. version: 1.21.3 Game version 1.21.3 version: 1.21.4

Comments

@cecilia-sanare
Copy link

Expected behavior

The entire input is crafted and dropped on the ground.

Observed/Actual behavior

Acts as if q was pushed on its own and crafts a single result and drops it.

Steps/models to reproduce

  • Open a crafting table
  • Place 2 or more logs in the crafting table
  • Push Ctrl + Q while hovering over the planks

Plugin and Datapack List

/plugins
Server Plugins (0):

/datapack list
There are 3 data pack(s) enabled: [vanilla (built-in)], [file/bukkit (world)], [paper (built-in)]
There are no more data packs available

Paper version

This server is running Paper version 1.21.3-81-master@da71382 (2024-12-03T14:58:13Z) (Implementing API version 1.21.3-R0.1-SNAPSHOT)
You are running the latest version
This server is running Paper version 1.21.4-15-master@bb76819 (2024-12-15T09:48:21Z) (Implementing API version 1.21.4-R0.1-SNAPSHOT)
You are running the latest version

Other

No response
@papermc-sniffer papermc-sniffer bot added the version: 1.21.3 Game version 1.21.3 label Dec 22, 2024
@Lulu13022002 Lulu13022002 added status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. version: 1.21.4 and removed status: needs triage labels Dec 22, 2024
@Lulu13022002
Copy link
Contributor

Can replicate that, related to https://github.com/PaperMC/Paper/blob/master/patches/server/0548-Fix-PlayerDropItemEvent-using-wrong-item.patch#L52

Owen1212055 added a commit that referenced this issue Dec 26, 2024
@Owen1212055
Remove itemstack mutation on player drop method
6cc87f8 
This appears to cause alot of issues, as the general assumption when calling this method is that the itemstack would not be mutated.

The dupe that this was meant to resolve was patched.

Fixes #11520 / #11765
@Owen1212055 Owen1212055 linked a pull request Dec 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: parity status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. version: 1.21.3 Game version 1.21.3 version: 1.21.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove itemstack mutation on player drop method PaperMC/Paper
4 participants
@cecilia-sanare @Machine-Maker @Lulu13022002 and others