Adding the block outside the course page should be disabled. #37
Comments
hohno-panopto
added a commit
that referenced
this issue
Oct 14, 2016
Merge from Panopto private repository. - Update the code to follow Moodle coding guideline. - Fix issues reported on GitHub #26, #35, #37 - Add help message to setting items. - Change the default setting of “Asynchronous enrollment sync” and “Automatically provision newly created courses” as Yes. - Minimum Moodle version is set to 2.7.
|
Fixed by 4572d44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the block can be added nearly anywhere in Moodle, it makes little sense since the block relies on course data and enrolments. Adding it to "Site page" or any admin page will result in fatal error on attempt to "provision the course".
In theory it is possible to add it within the mod, that will probably not cause error, but will display a duplicated the data of any panopto block within the same course (since there is only one configuration record per course in block_panopto_foldermap). This is inconsistent with the idea others mod-enabled blocks are following that allows a unique content if block is within the mod. Also, it is not clear what to do on block deletion within mod, if #36 is applied, it would need to determine that other blocks exist in course and skip cleanup on deletion.
So for current state, adding the block outside the course page should be disabled. More work is needed if one wish to have possibility to add it somewhere else in Moodle.
Issue is fixed in lucisgit@0beda49
The text was updated successfully, but these errors were encountered: