You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nowhere in the code passes on_update_name so this should be removed.
I added that as defensive code in case we ever do use it. If someone were to use it they would likely have an unexpected result, as the code would break in an unrelated place. I'm ok with removing it as long as this sort of protection is still available; if we change how the RecordUpdater is created/passed that will probably handle it.
In
PandABlocks-ioc/src/pandablocks_ioc/ioc.py
Lines 663 to 682 in 8e25d64
A record updater is created to send data back to the panda.
on_update_name
so this should be removed.record_updater
, which can be merged with the passed inon_update
.on_update
which aren't_RecordUpdater.update
s to also be given a_RecordUpdater
.The text was updated successfully, but these errors were encountered: