add Append command #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderWells-diamond
requested changes
Aug 8, 2023
There was a problem hiding this comment.
Thank you for the PR. It looks useful.
One required change as per my suggestion.
Could you please add one-or-more tests? Similar, easily adaptable ones are for example test_connect_put_multi_line() in tests/test_pandablocks.py. Any of the test_connect_put_* tests should show you examples.
coretl
reviewed
Aug 8, 2023
Co-authored-by: Alexander Wells <[email protected]>
Co-authored-by: Tom C (DLS) <[email protected]>
Co-authored-by: Tom C (DLS) <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 96.35% 96.37% +0.02%
==========================================
Files 12 12
Lines 1151 1159 +8
==========================================
+ Hits 1109 1117 +8
Misses 42 42
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Append command for SEQ table usage.