Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler error on Windows #3

Open
dirk-zimoch opened this issue May 27, 2021 · 1 comment
Open

Compiler error on Windows #3

dirk-zimoch opened this issue May 27, 2021 · 1 comment

Comments

@dirk-zimoch
Copy link

When compiling for Windows (actually cross-compiling using cl in wine), I get the following error:

z:\git\adpandablocks\adpandablocksapp\src\adpandablocks.cpp(1044): error C2131: expression did not evaluate to a constant
z:\git\adpandablocks\adpandablocksapp\src\adpandablocks.cpp(1044): note: failure was caused by a read of a variable outside its lifetime
z:\git\adpandablocks\adpandablocksapp\src\adpandablocks.cpp(1044): note: see usage of 'readBytes'

Not all compilers allow variable length arrays on the stack. It is probably more portable to use malloc().

@thomascobb
Copy link

Hi Dirk, thanks for the report. Unfortunately everyone who has worked on this codebase in the past has now left Diamond, so we're short of effort on this repo. If you have a patch I'd gladly accept it, otherwise it may be a while before this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants