Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test navigation_service.dart #1525

Closed
palisadoes opened this issue Feb 18, 2023 · 6 comments
Closed

Test navigation_service.dart #1525

palisadoes opened this issue Feb 18, 2023 · 6 comments
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Feb 18, 2023

The Talawa code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file:

lib/services/navigation_service.dart
  • When complete, all methods, classes and/or functions in the file will need to be tested.
  • Our test/ folder has the same structure as the lib folder. Place your test file in the equivalent folder under test/. You may need to create the appropriate directory structure to do this.
  • Current test code coverage for this file can be found here

IMPORTANT:

Please refer to this issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
  • You can verify your own code coverage by creating an account at Codecov.io
  • No functionality must be removed to achieve this goal.
@palisadoes palisadoes added the bug Something isn't working label Feb 18, 2023
@github-actions github-actions bot added test Testing application unapproved Unapproved, needs to be triaged labels Feb 18, 2023
@palisadoes palisadoes added points 01 good first issue Good for newcomers and removed bug Something isn't working labels Feb 18, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 6, 2023
@github-actions
Copy link

This issue did not get any activity in the past 180 days and thus has been closed. Please check if the newest release or develop branch has it fixed. Please, create a new issue if the issue is not fixed.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2023
@palisadoes palisadoes reopened this Oct 18, 2023
@github-actions github-actions bot removed the no-issue-activity No issue activity label Oct 20, 2023
@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Oct 31, 2023
@github-actions github-actions bot removed the no-issue-activity No issue activity label Nov 21, 2023
@Dante291
Copy link
Contributor

@palisadoes @noman2002 I would like to work on this.

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Nov 21, 2023
@Dante291 Dante291 removed their assignment Nov 25, 2023
Copy link

github-actions bot commented Dec 6, 2023

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 6, 2023
@github-actions github-actions bot removed the no-issue-activity No issue activity label Dec 19, 2023
@Dante291
Copy link
Contributor

@noman2002 Navigation service has 100% coverage so this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants